Skip to content

RHIDP-3974 managing authorization using the Web UI #633

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Gerry-Forde merged 7 commits into from
Nov 4, 2024
Merged

RHIDP-3974 managing authorization using the Web UI #633

Gerry-Forde merged 7 commits into from
Nov 4, 2024

Conversation

@themr0c
Copy link
Member

@themr0c themr0c commented Oct 16, 2024 •
edited by jmagak
Loading

Some xref statements depend on #631.

IMPORTANT: Do Not Merge - To be merged by Docs Team Only

Version(s): 1.3.1

Issue: https://issues.redhat.com/browse/RHIDP-3974

Link to docs preview: https://redhat-developer.github.io/red-hat-developers-documentation-rhdh/pr-633/authorization/#proc-rbac-ui-manage-roles_title-authorization

Reviews:

Additional information:

@themr0c themr0c requested a review from hmanwani-rh October 16, 2024 15:32
@rhdh-bot
Copy link
Collaborator

rhdh-bot commented Oct 16, 2024 •
edited
Loading

Updated preview: https://redhat-developer.github.io/red-hat-developers-documentation-rhdh/pr-633/ @ 11/04/24 17:06:00

albarbaro
albarbaro approved these changes Oct 17, 2024
View reviewed changes
Copy link
Member

@albarbaro albarbaro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@themr0c themr0c requested a review from jmagak October 21, 2024 10:30
@jmagak
Copy link
Member

jmagak commented Oct 22, 2024

Hi @themr0c , LTGM.

@Gerry-Forde Gerry-Forde merged commit 37a310d into redhat-developer:main Nov 4, 2024
2 checks passed
@themr0c
Copy link
Member Author

themr0c commented Nov 5, 2024

/cherry-pick release-1.3

@openshift-cherrypick-robot
Copy link
Contributor

openshift-cherrypick-robot commented Nov 5, 2024

@themr0c: #633 failed to apply on top of branch "release-1.3":

Applying: RHIDP-3974 managing authorization using the Web UI
Using index info to reconstruct a base tree...
M	assemblies/assembly-configuring-authorization-in-rhdh.adoc
Falling back to patching base and 3-way merge...
Removing modules/authorization/proc-rbac-ui-manage-roles.adoc
Auto-merging assemblies/assembly-configuring-authorization-in-rhdh.adoc
CONFLICT (content): Merge conflict in assemblies/assembly-configuring-authorization-in-rhdh.adoc
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
hint: When you have resolved this problem, run "git am --continue".
hint: If you prefer to skip this patch, run "git am --skip" instead.
hint: To restore the original branch and stop patching, run "git am --abort".
hint: Disable this message with "git config advice.mergeConflict false"
Patch failed at 0001 RHIDP-3974 managing authorization using the Web UI

In response to this:

/cherry-pick release-1.3

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@themr0c
Copy link
Member Author

themr0c commented Nov 5, 2024

/cherry-pick release-1.3

@openshift-cherrypick-robot
Copy link
Contributor

openshift-cherrypick-robot commented Nov 5, 2024

@themr0c: #633 failed to apply on top of branch "release-1.3":

Applying: RHIDP-3974 managing authorization using the Web UI
Using index info to reconstruct a base tree...
M	assemblies/assembly-configuring-authorization-in-rhdh.adoc
Falling back to patching base and 3-way merge...
Removing modules/authorization/proc-rbac-ui-manage-roles.adoc
Auto-merging assemblies/assembly-configuring-authorization-in-rhdh.adoc
CONFLICT (content): Merge conflict in assemblies/assembly-configuring-authorization-in-rhdh.adoc
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
hint: When you have resolved this problem, run "git am --continue".
hint: If you prefer to skip this patch, run "git am --skip" instead.
hint: To restore the original branch and stop patching, run "git am --abort".
hint: Disable this message with "git config advice.mergeConflict false"
Patch failed at 0001 RHIDP-3974 managing authorization using the Web UI

In response to this:

/cherry-pick release-1.3

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

themr0c added a commit to themr0c/red-hat-developers-documentation-rhdh that referenced this pull request Nov 5, 2024
@themr0c @dzemanov @Gerry-Forde
RHIDP-3974 managing authorization using the Web UI (redhat-developer#633
02f2b6d 
)

* RHIDP-3974 managing authorization using the Web UI

Signed-off-by: Fabrice Flore-Thébault <[email protected]>

* Update assemblies/assembly-managing-authorizations-by-using-the-rhdh-web-ui.adoc

Co-authored-by: Dominika Zemanovicova <[email protected]>

---------

Signed-off-by: Fabrice Flore-Thébault <[email protected]>
Co-authored-by: Dominika Zemanovicova <[email protected]>
Co-authored-by: Gerry-Forde <[email protected]>
@themr0c themr0c mentioned this pull request Nov 5, 2024
Merged
4 tasks
themr0c added a commit that referenced this pull request Nov 5, 2024
@themr0c @dzemanov @Gerry-Forde
RHIDP-3974 managing authorization using the Web UI (#633) (#674)
2d4480f 
Co-authored-by: Dominika Zemanovicova <[email protected]>
Co-authored-by: Gerry-Forde <[email protected]>
@themr0c themr0c deleted the RHIDP-3974-managing-authorization-using-the-Web-UI branch November 6, 2024 08:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Gerry-Forde Gerry-Forde Gerry-Forde approved these changes

@hmanwani-rh hmanwani-rh Awaiting requested review from hmanwani-rh

@PatAKnight PatAKnight Awaiting requested review from PatAKnight

@jmagak jmagak Awaiting requested review from jmagak

+2 more reviewers

@dzemanov dzemanov dzemanov left review comments

@albarbaro albarbaro albarbaro approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

Peer review done 📘 Ready to merge 💂 Technical review done ⛅ Any procedure has been succesfully tested

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@themr0c @rhdh-bot @jmagak @openshift-cherrypick-robot @dzemanov @Gerry-Forde @albarbaro